Update formatter to write to file #133
Conversation
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 3 3
Lines 368 368
=======================================
Hits 338 338
Misses 30 30
Continue to review full report at Codecov.
|
| result_path = File.join(::SimpleCov.coverage_path, RESULT_FILE_NAME) | ||
| if File.writable?(result_path) | ||
| File.write(result_path, result['codecov']) | ||
| puts "Coverage report generated to #{result_path}.\#{result}" |
There was a problem hiding this comment.
@thomasrockhu Was it intended to leave the result in this logging statement? Printing the fairly large (depending on the number of tests) result adds significant clutter to the logged test output.
There was a problem hiding this comment.
@davidrunger no not at all, apologies for the spam. I'll make a PR this week and release a new version that prints a shortened version (e.g. 4 ish lines?). Is that acceptable?
There was a problem hiding this comment.
@thomasrockhu : No worries; not a big deal! :) Although personally I'd probably prefer that no lines be printed when it is successful, I can on the other hand certainly understand the possible benefits for debugging purposes, and printing 4ish lines also sounds fine to me. 👍Thanks!
There was a problem hiding this comment.
@davidrunger, this has been updated in 0.4.3. Let me know if you run into issues!
There was a problem hiding this comment.
Thank you, @thomasrockhu ! 🙇♂️ Version 0.4.3 works great. 👍
* Wrap file creation in try/catch * Update CHANGELOG
No description provided.