Skip to content

fix: copy over globs translate #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2025
Merged

fix: copy over globs translate #619

merged 4 commits into from
Feb 13, 2025

Conversation

thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Feb 8, 2025

Copy link

codecov bot commented Feb 8, 2025

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
3565 5 3560 0
View the top 3 failed test(s) by shortest run time
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError
api.temp.calculator.test_calculator::test_divide
Stack Traces | 0.001s run time
def
                test_divide():
                > assert Calculator.divide(1, 2) == 0.5
                E assert 1.0 == 0.5
                E + where 1.0 = <function Calculator.divide at 0x104c9eb90>(1, 2)
                E + where <function Calculator.divide at 0x104c9eb90> = Calculator.divide
                .../temp/calculator/test_calculator.py:30: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

github-actions bot commented Feb 8, 2025

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@thomasrockhu-codecov thomasrockhu-codecov merged commit 85dbe9e into main Feb 13, 2025
26 of 28 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the th/globs branch February 13, 2025 15:22
antoninbas added a commit to antoninbas/antrea that referenced this pull request Feb 21, 2025
The codecov CLI has been updated, and the glob translation logic is
different. We need the '**' pattern to match the full path.
See codecov/codecov-cli#619

We also remove the trailing wildcard, as it seems that we only ever use
the .cov.out suffix for these tests.

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antrea-io/antrea that referenced this pull request Feb 22, 2025
The codecov CLI has been updated, and the glob translation logic is
different. We need the '**' pattern to match the full path.
See codecov/codecov-cli#619

We also remove the trailing wildcard, as it seems that we only ever use
the .cov.out suffix for these tests.

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antoninbas/antrea that referenced this pull request Feb 24, 2025
The codecov CLI has been updated, and the glob translation logic is
different. We need the '**' pattern to match the full path.
See codecov/codecov-cli#619

We also remove the trailing wildcard, as it seems that we only ever use
the .cov.out suffix for these tests.

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antoninbas/antrea that referenced this pull request Feb 24, 2025
The codecov CLI has been updated, and the glob translation logic is
different. We need the '**' pattern to match the full path.
See codecov/codecov-cli#619

We also remove the trailing wildcard, as it seems that we only ever use
the .cov.out suffix for these tests.

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antoninbas/antrea that referenced this pull request Feb 24, 2025
The codecov CLI has been updated, and the glob translation logic is
different. We need the '**' pattern to match the full path.
See codecov/codecov-cli#619

We also remove the trailing wildcard, as it seems that we only ever use
the .cov.out suffix for these tests.

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antrea-io/antrea that referenced this pull request Feb 25, 2025
The codecov CLI has been updated, and the glob translation logic is
different. We need the '**' pattern to match the full path.
See codecov/codecov-cli#619

We also remove the trailing wildcard, as it seems that we only ever use
the .cov.out suffix for these tests.

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antrea-io/antrea that referenced this pull request Feb 25, 2025
The codecov CLI has been updated, and the glob translation logic is
different. We need the '**' pattern to match the full path.
See codecov/codecov-cli#619

We also remove the trailing wildcard, as it seems that we only ever use
the .cov.out suffix for these tests.

Signed-off-by: Antonin Bas <[email protected]>
antoninbas added a commit to antrea-io/antrea that referenced this pull request Feb 25, 2025
The codecov CLI has been updated, and the glob translation logic is
different. We need the '**' pattern to match the full path.
See codecov/codecov-cli#619

We also remove the trailing wildcard, as it seems that we only ever use
the .cov.out suffix for these tests.

Signed-off-by: Antonin Bas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows fails to upload coverage if multiple files are specified Add globbing support
2 participants