Skip to content

feat(nx-plugin): add crystal utils #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Jul 25, 2024
Merged

feat(nx-plugin): add crystal utils #754

merged 33 commits into from
Jul 25, 2024

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Jul 18, 2024

Preparation for #619

This PR includes:

  • basic createNodes function
    • add configuration target to projects without a code-pushup config file
  • relevant testing helpers for the createNodes function
  • types, constants and utils for future logic
  • test helper refactoring and documentation over tests

Command example:

  • nx run-many --target=code-pushup--configuration --exclude=test-utils

Copy link

github-actions bot commented Jul 18, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 8187c6a with source commit ba4f181.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 55 🟡 56 ↑ +1.1
Code coverage 🟡 90 🟡 90 ↓ −0.1
Custom checks 🟡 67 🟡 67
Security 🟢 100 🟢 100
Updates 🟡 78 🟡 78
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99

🗃️ Groups

👍 1 group improved, 👎 1 group regressed
🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 55 🟡 56 ↑ +1.1
Code coverage Code coverage metrics 🟡 90 🟡 90 ↓ −0.1

18 other groups are unchanged.

🛡️ Audits

👍 4 audits improved, 👎 4 audits regressed, 12 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟨 3.0 s ↓ −5 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟨 2.7 s ↓ −3 %
Lighthouse Speed Index 🟨 5.5 s 🟨 5.7 s ↑ +2 %
Lighthouse First Meaningful Paint 🟨 2.8 s 🟨 2.7 s ↓ −3 %
Lighthouse Time to Interactive 🟥 14.1 s 🟥 15.5 s ↑ +10 %
Code coverage Branch coverage 🟨 83.6 % 🟨 83.9 % ↑ +0 %
Code coverage Function coverage 🟩 92.4 % 🟩 92.2 % ↓ +0 %
Code coverage Line coverage 🟩 91.3 % 🟩 91.2 % ↓ +0 %
Lighthouse JavaScript execution time 🟥 7.7 s 🟥 9.6 s ↑ +25 %
Lighthouse Total Blocking Time 🟥 5,740 ms 🟥 7,190 ms ↑ +25 %
Lighthouse Metrics 🟩 14119 🟩 15549 ↑ +10 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,786 KiB 🟩 Total size was 1,785 KiB ↓ +0 %
Lighthouse Max Potential First Input Delay 🟥 2,250 ms 🟥 3,470 ms ↑ +54 %
Lighthouse Minimizes main-thread work 🟥 18.6 s 🟥 19.8 s ↑ +6 %
Lighthouse Uses efficient cache policy on static assets 🟨 27 resources found 🟨 27 resources found ↑ +0 %
Lighthouse Server Backend Latencies 🟩 130 ms 🟩 230 ms ↑ +85 %
Lighthouse Initial server response time was short 🟩 Root document took 310 ms 🟩 Root document took 390 ms ↑ +25 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,130 ms 🟥 Potential savings of 1,170 ms ↑ +4 %
Lighthouse Avoids an excessive DOM size 🟥 2,191 elements 🟥 2,206 elements ↑ +1 %
Lighthouse Network Round Trip Times 🟩 30 ms 🟩 20 ms ↓ −15 %

489 other audits are unchanged.

@BioPhoton BioPhoton changed the title Add crystal utils feat(nx-plugin): add crystal utils Jul 18, 2024
@BioPhoton BioPhoton requested review from Tlacenka and matejchalk July 18, 2024 16:30
@BioPhoton BioPhoton marked this pull request as ready for review July 18, 2024 16:31
@BioPhoton BioPhoton requested a review from matejchalk July 23, 2024 14:44
BioPhoton and others added 2 commits July 24, 2024 12:02
# Conflicts:
#	packages/nx-plugin/src/index.ts
#	testing/test-utils/src/index.ts
@BioPhoton BioPhoton requested a review from matejchalk July 24, 2024 10:10
@BioPhoton BioPhoton requested a review from matejchalk July 24, 2024 10:30
@BioPhoton BioPhoton removed the request for review from matejchalk July 24, 2024 10:36
matejchalk
matejchalk previously approved these changes Jul 25, 2024
Co-authored-by: Matěj Chalk <[email protected]>
Co-authored-by: Matěj Chalk <[email protected]>
@BioPhoton BioPhoton merged commit 4df1fc2 into main Jul 25, 2024
30 checks passed
@BioPhoton BioPhoton deleted the add-crystal-utils branch July 25, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants