Skip to content

release-24.1: deps: upgrade [email protected] to version 1.43.1 #140157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

wenyihu6
Copy link
Contributor

@wenyihu6 wenyihu6 commented Jan 30, 2025

Backport 1/1 commits from #133563.

/cc @cockroachdb/release


This patch upgrades sarama to v1.43.1 to pick up fix IBM/sarama#2826 related to the kafka
throttling feature we supported in v24.1. It addresses a race condition where
producer could be blocked.

Epic: none

Release note: fixed a race condition in sarama when kafka throttling is
enabled


Release justification: important fix where kafka producers may be blocked when being throttled

This patch upgrades sarama to v1.43.1 to pick up fix IBM/sarama#2826 related to the kafka
throttling feature we supported in v24.1. It addresses a race condition where
producer could be blocked.

Epic: none

Release note: fixed a race condition in sarama when kafka throttling is
enabled

Epic: none

Release note: fixed a race condition in sarama when kafka throttling is
enabled

# Conflicts:
#	go.mod
#	go.sum
Copy link

blathers-crl bot commented Jan 30, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 30, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@wenyihu6 wenyihu6 marked this pull request as ready for review January 30, 2025 22:56
@wenyihu6 wenyihu6 requested a review from a team as a code owner January 30, 2025 22:56
@rharding6373 rharding6373 requested a review from asg0451 January 30, 2025 22:59
@wenyihu6 wenyihu6 merged commit 02fec02 into cockroachdb:release-24.1 Jan 31, 2025
19 of 20 checks passed
@wenyihu6 wenyihu6 deleted the backport24.1-133563 branch February 18, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants