Skip to content

cnes-scan 1.4.0 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 20, 2019
Merged

cnes-scan 1.4.0 #11

merged 17 commits into from
Aug 20, 2019

Conversation

louisjdmartin
Copy link
Member

@louisjdmartin louisjdmartin commented Jul 15, 2019 •
edited
Loading

The new release of cnes-report work as plugin, so this PR updates cnes-scan to work with latest cnes-report.

Changes:

  • Web interface to generate report is removed (Web interface is now managed by cnesreport)
  • Some cleaning in the repo (remove JetBrains index files and update gitignore)
  • Some improvement to GUI (GUI enhancement #6)
  • Load jQuery when needed (add compatibility with SonarQube 7)
  • Settings about cnes-report are removed

Warning:

  • This new version of cnes-scan is not working with old version of cnes-report (min version: 2.2.0)

@begarco begarco self-requested a review August 7, 2019 14:14
begarco
begarco suggested changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@begarco begarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at & fix the 3 comments then PR will be accepted.

@louisjdmartin louisjdmartin requested a review from begarco August 8, 2019 08:12
begarco
begarco suggested changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@begarco begarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct your English!

@louisjdmartin louisjdmartin merged commit 1d769b5 into master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begarco begarco begarco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louisjdmartin @begarco