-
-
Notifications
You must be signed in to change notification settings - Fork 30
Unique target group IDs and health check config per target group #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jnonino
merged 4 commits into
cn-terraform:main
from
datadrivers:feat/health-check-config-per-port
Apr 2, 2025
Merged
Unique target group IDs and health check config per target group #65
jnonino
merged 4 commits into
cn-terraform:main
from
datadrivers:feat/health-check-config-per-port
Apr 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce random IDs for target groups to ensure unique naming with replacement on config changes. Added validation for the name prefix to enforce a maximum length of 15 characters. This change improves resource management and enforces stricter validation rules.
nickreynke
commented
Apr 1, 2025
Simplify attribute access in `main.tf` by replacing `lookup` calls with direct references to `each.value` properties. Updated `variables.tf` to define explicit object types, improving type safety and clarity for HTTP/HTTPS port variable definitions.
Enhanced health check configuration by allowing per-resource overrides using the `lookup` function. Introduced new optional variables for health check settings, providing greater flexibility and customization. This change ensures a more tailored setup for different target groups.
Improve clarity and provide protocol-specific details for GRPC. This ensures users understand the different allowed code ranges for HTTP/HTTPS and GRPC.
Hey @jnonino! Another PR for review :) The only thing I am not sure about is #65 (comment) |
The new unique naming concept for target groups fixes a bug where Terraform wants to replace the target group with another one with the same name. To make use of the |
jnonino
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
Copilot summary:
This pull request includes several updates to the
README.md
andmain.tf
files to enhance the configuration and behavior of the load balancer and its associated resources. The most important changes include adding new requirements and providers, updating the input variables, and improving the configuration of target groups and listeners.Updates to
README.md
:null
andrandom
providers and listed their versions.null_resource
andrandom_id
in the resources section.http_ports
andhttps_ports
to include more detailed configuration options.name_prefix
input variable.target_group_health_check_protocol
.Enhancements to
main.tf
:null_resource
andrandom_id
resources to manage HTTP and HTTPS target group configurations and ensure unique naming. [1] [2]aws_lb_target_group
resources to use the newrandom_id
for unique naming and improved health check configurations. [1] [2]aws_lb_listener
resources to directly use values from the configuration without lookup functions forredirect
andfixed-response
types. [1] [2] [3] [4]