Add support for health check port and protocol version #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new variable `target_group_health_check_port` to allow specifying the port for target group health checks. Updated the associated logic in `main.tf` to utilize this new variable, defaulting to "traffic-port". Updated documentation and README accordingly.
Introduced the `target_group_protocol_version` parameter for target groups, defaulting to "HTTP1". This enhances flexibility, allowing specification of HTTP1, HTTP2, or GRPC for protocol version.
|
@jnonino If you have time please review this PR :) The checks are running successfully within our repository: https://github.com/datadrivers/terraform-aws-ecs-alb/actions We need support for custom ports and protocol versions for health checks. |
jnonino
approved these changes
Mar 27, 2025
github-project-automation
bot
moved this from 🆕 New
to ✅ Done
in CN Services - Terraform Modules
|
Hi @nickreynke, approved, merged and released!!! Thanks for contributing!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
README.md,main.tf, andvariables.tffiles to improve the configuration and functionality of the load balancer module. The most important changes include updating provider versions, adding support for protocol versions, and enhancing health check configurations.Updates to Provider Versions:
README.md: Updated AWS provider to version 5.92.0 and Random provider to version 3.7.1.Enhancements to Listener and Target Group Configurations:
README.md: Updated default HTTP and HTTPS listener configurations to includetarget_group_protocolandtarget_group_protocol_versionfields. [1] [2]main.tf: Addedprotocol_versiontoaws_lb_target_groupresources for both HTTP and HTTPS target groups. [1] [2]Health Check Configuration Improvements:
README.md: Addedtarget_group_health_check_portto the health check configuration options.main.tf: Includedportin the health check block ofaws_lb_target_groupresources.variables.tf: Introduced a new variabletarget_group_health_check_portwith a default value of"traffic-port".