USCSS Secret Agent PMC shipmap and NSG/PVE #858
Conversation
|
Lil silly, isn't it? I get it's a Conrad reference, but its a tad goofy. |
spartanbobby
changed the title
Test merge deployment history:Test Merge Deployed @ 03/24/2025 14:12:20 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/24/2025 14:17:04 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/24/2025 14:20:53 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Removed @ 03/24/2025 21:35:25 +00:00:Server InstancePVECM: Green Test Merge Deployed @ 03/25/2025 09:27:19 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/25/2025 10:44:35 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/25/2025 10:47:05 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/25/2025 10:49:48 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/25/2025 15:46:24 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/25/2025 18:26:20 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/25/2025 19:00:06 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/25/2025 19:09:09 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/25/2025 20:14:05 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/25/2025 20:19:01 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/25/2025 22:41:01 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/26/2025 12:36:24 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 384d501 Test Merge Updated @ 03/26/2025 18:48:11 +00:00:Server InstancePVECM: Green Merged Bylordloko RevisionOrigin: 08f2790 Test Merge Updated @ 03/26/2025 22:31:30 +00:00:Server InstancePVECM: Green Merged BySpartanBobby RevisionOrigin: 08f2790 Test Merge Removed @ 03/28/2025 00:26:40 +00:00:Server InstancePVECM: Green Test Merge Deployed @ 03/28/2025 19:37:19 +00:00:Server InstancePVECM: Green Merged Bylordloko RevisionOrigin: 934ac37 Test Merge Removed @ 03/30/2025 01:53:23 +00:00:Server InstancePVECM: Green Test Merge Deployed @ 04/07/2025 23:32:08 +00:00:Server InstancePVECM: Red Merged ByRob606 RevisionOrigin: 59a7196 Test Merge Removed @ 04/09/2025 04:28:28 +00:00:Server InstancePVECM: Red Test Merge Deployed @ 04/09/2025 21:39:38 +00:00:Server InstancePVECM: Red Merged Bylordloko RevisionOrigin: a688e1c Test Merge Updated @ 04/10/2025 00:46:01 +00:00:Server InstancePVECM: Red Merged ByPandora029 RevisionOrigin: 383da65 Test Merge Deployed @ 04/10/2025 19:19:37 +00:00:Server InstancePVECM: Blue Merged Bylordloko RevisionOrigin: f42638d Test Merge Removed @ 04/11/2025 00:18:30 +00:00:Server InstancePVECM: Red Test Merge Removed @ 04/11/2025 13:14:25 +00:00:Server InstancePVECM: Blue Test Merge Deployed @ 04/12/2025 20:55:27 +00:00:Server InstancePVECM: Green Merged Bylordloko RevisionOrigin: f42638d Test Merge Removed @ 04/13/2025 00:15:27 +00:00:Server InstancePVECM: Green Test Merge Deployed @ 05/04/2025 20:18:57 +00:00:Server InstancePVECM: Green Merged ByStinkethStonketh RevisionOrigin: 7e020da Test Merge Removed @ 05/05/2025 06:05:07 +00:00:Server InstancePVECM: Green Test Merge Deployed @ 05/22/2025 15:15:54 +00:00:Server InstancePVECM: Green Merged BySuno RevisionOrigin: 7136ecf Test Merge Deployed @ 05/22/2025 15:40:39 +00:00:Server InstancePVECM: Red Merged BySuno RevisionOrigin: 7136ecf Test Merge Removed @ 05/22/2025 17:36:10 +00:00:Server InstancePVECM: Red Test Merge Removed @ 05/22/2025 20:19:51 +00:00:Server InstancePVECM: Green Test Merge Deployed @ 05/22/2025 20:51:11 +00:00:Server InstancePVECM: Blue Merged ByStinkethStonketh RevisionOrigin: 030879c Test Merge Removed @ 05/23/2025 00:53:51 +00:00:Server InstancePVECM: Blue Test Merge Deployed @ 05/23/2025 09:02:28 +00:00:Server InstancePVECM: Green Merged BySuno RevisionOrigin: 1056165 Test Merge Removed @ 05/23/2025 13:07:39 +00:00:Server InstancePVECM: Green Test Merge Deployed @ 05/25/2025 09:11:12 +00:00:Server InstancePVECM: Red Merged ByAndroBetel RevisionOrigin: 1c66ba4 Test Merge Removed @ 05/25/2025 17:18:43 +00:00:Server InstancePVECM: Red |
|
Going to maintain a list of things I had to fix/feedback in this comment most, if not all of these problems are esoteric mapping things and no one should feel upset Layering: things like handrails, tables, ledges should not be layered, instead you should layer the things around these props, since layering them themself can cause some problems, aswell you want to layer items in the 2.1 to 4.9 range, never below or above. 2 is the tile layer, 5 is the mob layer, meaning if you go 2 or below your items will be below a tile, and 5 or above it will be above a marine mapprops, things like the sensor tower should be avoided since that item does things, basically any kind of prop that does something potentially unwanted should be avoided or a new prop subtype version should be made some items had their direction set to "Null" this isn't a valid direction and will cause the map to fail checks, things like all the maps lights had this problem, it's not a big deal in some places there were dupplicate items causing checkfailures (platforms ontop of platforms) that's not a big deal icon states: changing the icon_states of tiles is a big no-no, platform edges: It's preferred to use the coded platform edge subtype instead of iconswapping platforms themselves, causes less problems aswell any item that has a coded in directional in it's subtype, better to just use that, for example hypersleep/flipped disposal pipe trisections have a small arrow telling you where the trash is going to go, make sure to align that properly so trash doesn't shoot back thru the pipe it came in from pixeloffsetting: try to avoid pixel offsetting things that could block movement, like a handrail, because while appearing somewhere else visually It will still block the "place" it's coded to occupy |
|
The map should be safe to run on your own, I will not be available to oversee any bugfixes for the time being |
spartanbobby
changed the title
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 14 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
https: //github.com/cmss13-devs/pull/858 Co-Authored-By: spartanbobby <[email protected]>
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 14 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
spartanbobby
changed the title
About the pull request
PR for soullessmagpies PMC ship, I named it USCSS Secret Agent, after the conrad book
subtype of the nsg23 pmc weapon w/ slightly better stats so it can be used as an m41a analog without chucking players
Explain why it's good for the game
cool
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 SpartanBobby, Soullessmagpie
mapadd: USCSS Secret Agent PMC ship
add: NSG/PVE
/:cl: