Skip to content

Add C++14 programming language #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2020
Merged

Add C++14 programming language #1132

merged 1 commit into from
Sep 27, 2020

Conversation

andreyv
Copy link
Member

@andreyv andreyv commented Aug 24, 2019

Tests are currently disabled (but passed locally for me). The current Ubuntu version used with Travis CI has GCC 4.8, which doesn't support C++14. CI needs to be updated at least to Ubuntu 16.04, which has GCC 5.


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 24, 2019

Codecov Report

Merging #1132 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1132      +/-   ##
==========================================
- Coverage   62.01%   61.95%   -0.07%     
==========================================
  Files         230      231       +1     
  Lines       16604    16623      +19     
==========================================
+ Hits        10297    10298       +1     
- Misses       6307     6325      +18     
Flag Coverage Δ
#functionaltests 45.77% <ø> (+0.02%) ⬆️
#unittests 43.31% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cms/grading/languages/cpp11_gpp.py 100.00% <ø> (ø)
cms/grading/languages/cpp14_gpp.py 100.00% <ø> (ø)
cms/db/base.py 84.04% <0.00%> (-7.45%) ⬇️
cms/grading/Job.py 80.09% <0.00%> (-6.64%) ⬇️
cms/server/contest/handlers/contest.py 84.00% <0.00%> (-3.00%) ⬇️
cms/server/admin/handlers/base.py 67.45% <0.00%> (-1.70%) ⬇️
cms/io/rpc.py 90.44% <0.00%> (-1.37%) ⬇️
cms/io/triggeredservice.py 84.21% <0.00%> (-1.06%) ⬇️
cms/db/util.py 50.37% <0.00%> (-0.75%) ⬇️
cms/service/esoperations.py 78.01% <0.00%> (-0.71%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faba26f...293a587. Read the comment docs.

LANG_CPP14 could be a member of e.g. ALL_LANGUAGES_AND_DIALECTS to
avoid running all the same tests as for LANG_CPP11, but for now it
is added to ALL_LANGUAGES.
@andreyv andreyv merged commit 4b1cb3f into cms-dev:master Sep 27, 2020
@andreyv andreyv deleted the cxx14 branch September 27, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant