Skip to content

Translate Yes/No messages in the Official column of the submissions row #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Translate Yes/No messages in the Official column of the submissions row #1080

merged 1 commit into from
Nov 27, 2018

Conversation

andreyv
Copy link
Member

@andreyv andreyv commented Nov 25, 2018

The strings are already in .pot, so no .pot update is needed.


This change is Reviewable

The strings are already in .pot, so no .pot update is needed.
@codecov
Copy link

codecov bot commented Nov 25, 2018

Codecov Report

Merging #1080 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1080      +/-   ##
==========================================
+ Coverage   61.96%   61.99%   +0.03%     
==========================================
  Files         228      228              
  Lines       16457    16457              
==========================================
+ Hits        10198    10203       +5     
+ Misses       6259     6254       -5
Flag Coverage Δ
#functionaltests 45.97% <ø> (-0.01%) ⬇️
#unittests 43.11% <ø> (-0.01%) ⬇️
Impacted Files Coverage Δ
cms/server/admin/handlers/user.py 25.62% <0%> (-3.13%) ⬇️
cms/service/esoperations.py 80.85% <0%> (-2.84%) ⬇️
cms/service/ScoringService.py 66.15% <0%> (-1.54%) ⬇️
cms/io/service.py 70.12% <0%> (-1.22%) ⬇️
cms/grading/Job.py 88.15% <0%> (-0.95%) ⬇️
cms/db/util.py 50% <0%> (-0.76%) ⬇️
cms/db/filecacher.py 77.04% <0%> (-0.66%) ⬇️
cms/db/base.py 84.04% <0%> (ø) ⬆️
cms/io/rpc.py 90.78% <0%> (+0.34%) ⬆️
cms/server/admin/handlers/dataset.py 25.69% <0%> (+0.92%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c7943...5951c93. Read the comment docs.

Copy link
Member

@stefano-maggiolo stefano-maggiolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@stefano-maggiolo stefano-maggiolo merged commit 5951c93 into cms-dev:master Nov 27, 2018
@andreyv andreyv deleted the translate-official branch November 29, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants