Skip to content

Refactor and rewrite #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 22, 2024
Merged

Refactor and rewrite #27

merged 12 commits into from
Jun 22, 2024

Conversation

cmathews393
Copy link
Owner

Description

  1. Convert app to typer app
  2. Implement supercronic for scheduling logic
  3. Convert from requests library to httpx
  4. Add type hinting and ruff compliance
  5. Restructure modules and separate concerns better
  6. Updated documentation
  7. Added cover art import (Thanks @AverageDave93)
  8. Reconfigured logging to use loguru instead of print statements
  9. Reconfigured Dockerfile to use poetry for dependencies

Fixes #26, #25, #21, #9

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My code is properly type hinted
  • My code is Ruff compliant

@cmathews393 cmathews393 added bug Something isn't working enhancement New feature or request labels Jun 22, 2024
@cmathews393 cmathews393 merged commit 36365a9 into main Jun 22, 2024
1 check passed
@cmathews393 cmathews393 deleted the refactor branch September 2, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
1 participant