-
Notifications
You must be signed in to change notification settings - Fork 3
Update opentelemetry-js distribution to latest (v1.30.1) #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the old flags and also brings in some new unstable ones. Leaving our instrumentation attrs alone, switching over will break dashboards etc, let's do it another day
Upstream did the same export consolidation refactor as us, but over several minor releases so it was cleanest to take them all in one go. Tested export compression with OTEL_EXPORTER_OTLP_COMPRESSION=gzip This appears to be a new feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From v1.24.0 towards v1.30.1
semantic-conventions
Upstream now has two different deprecation cycles going on here, and an extra import specifier to select between them.:
opentelemetry-js
has yet to follow either deprecation, while I want to move this library's instrumentations forward to the latest HTTP convenations.semantic-conventions.js
.OTLP changes
This includes a pretty large refactor of OTLP exporting:
fetch()
implementaion that works nicely with Deno. The final OTLP export javascript is quite clean now - just promises, no callbacks. Nice!OTEL_EXPORTER_OTLP_COMPRESSION=gzip
). Implemented withCompressionStream
.deno --unstable-otel
instead.