Remove hardcoded github provider

[drselump14]

• Remove detailed GitHub provider
• Allow GitHub provider to be injected

Resolves #34
Follows up for PR #35

[nitrocode]

/test all

[nitrocode]

@drselump14 please add the repo root's versions.tf to examples/complete directory to fix test/bats and get the test/terratest to run.

[nitrocode]

/test all

[nitrocode]

/test all

[nitrocode]

/test all

[nitrocode]

/test all

[nitrocode]

This is not needed since there isn't an alias, the provider should be implicitly provided

[nitrocode]

There is a terratest error. Looks like it doesn't show an org in the api call which is odd since you're correctly passing in the owner and the integrations/github provider states in their docs that the organization input is deprecated.

Error: POST https://api.github.com/repos//terraform-github-repository-webhooks/hooks: 404 Not Found []

I'm unsure why the org is missing here.

Please troubleshoot and run the tests locally to reproduce and resolve.

[drselump14]

There is a terratest error. Looks like it doesn't show an org in the api call which is odd since you're correctly passing in the owner and the integrations/github provider states in their docs that the organization input is deprecated.

Error: POST https://api.github.com/repos//terraform-github-repository-webhooks/hooks: 404 Not Found []

I'm unsure why the org is missing here.

Please troubleshoot and run the tests locally to reproduce and resolve.

I'm unsure how to run terratest locally, but I can confirm that terraform apply --var-file fixtures.us-east-2.tfvars works with the latest commit.

[nitrocode]

/test all

[nitrocode]

cc: @Nuru please review when you get a chance. Requesting your help since you gave an in-depth set of steps in the previous PR and @drselump14 has taken it on to complete each one.

The tests pass and so far this looks pretty good to me. I think a second set of eyes would help here.

[nitrocode]

Nice job!

[mihaiplesa]

Looking forward to this.

[adamantike]

Can this change be considered for merge and release? It would also fix #37, which is avoiding higher-level modules (like cloudposse/terraform-aws-ecs-web-app) from using count or for_each.