Skip to content

fix: Default iops to null (#168) #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2024
Merged

fix: Default iops to null (#168) #176

merged 2 commits into from
Apr 15, 2024

Conversation

kbolino
Copy link
Contributor

@kbolino kbolino commented Apr 15, 2024

what

The default value of the iops variable is changed from 0 to null.

why

Resolves an issue with gp3 storage type when allocated storage is below 400 GB. This shouldn't cause problems in other cases, as the parameter is optional at the provider level.

references

@kbolino kbolino requested review from a team as code owners April 15, 2024 16:15
@kbolino kbolino requested review from nitrocode and gberenice April 15, 2024 16:15
@mergify mergify bot added the triage Needs triage label Apr 15, 2024
@gberenice
Copy link

/terratest

@gberenice
Copy link

@kbolino thank you for the contribution!
The tests are currently failing due to the combination of parameters that is not supported by Amazon RDS anymore:

Error: creating RDS DB Instance (eg-test-rds-test-37868): InvalidParameterCombination: RDS does not support creating a DB instance with the following combination: DBInstanceClass=db.t2.small, Engine=mysql, EngineVersion=5.7.44, LicenseModel=general-public-license. For supported combinations of instance class and database engine version, see the documentation.

Could I ask you to update the instance type to db.t3.micro in the examples? 🙏

@gberenice
Copy link

/terratest

gberenice
gberenice approved these changes Apr 15, 2024
View reviewed changes
Copy link

@gberenice gberenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gberenice gberenice merged commit ed5c31c into cloudposse:main Apr 15, 2024
@mergify mergify bot removed the triage Needs triage label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberenice gberenice gberenice approved these changes

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gp3 storage type also supports providing iops manually when storage is atleast 400gb.
2 participants
@kbolino @gberenice