Update to get rid of sensitive file warning from terraform

[brunzefb]

what

• Updated to local_sensitive_file resource, changed provider versions.

why

• This removes a terraform warning

[Gowiem]

/test all

[Gowiem]

LGTM 👍

[Gowiem]

@brunzefb Thanks for the contribution! Released as https://github.com/cloudposse/terraform-aws-key-pair/releases/tag/0.18.3

[ekristen]

@Gowiem I believe this should have been a major release instead of a patch.

Reasoning:

• the underlying providers where revved major versions.
• aws from 2 to 3
• local from 1 to 2

Background:

• I use renovatebot and make merge decisions based on semver and tests and changelog. Thankfully my tests caught this.

I believe 1.18.3 should be removed and 2.0.0 be created in its place or a note should be placed on 1.18.3 indicating it's a breaking change and create a 2.0.0 as well.

Thoughts?

[Gowiem]

@ekristen Good catch. Few things:

1. Cloud Posse has been avoiding major releases across all our modules similar to how Terraform was managed prior to v1.0 -- We believe we haven't reached a stable 1.0 release for our modules yet since Terraform wasn't 1.0.
2. That said, I could see this being a minor version bump instead of a patch which would get us closer to what you're thinking.
3. Lastly, I shouldn't have allowed the AWS provider version bump as it's unnecessary: This doesn't change our AWS provider functionality so therefore there is no reason to block usage of the 2.x AWS provider.

Considering that I will make some updates later today to push out a 0.19 release which reverts the 3.x requirement. I'll also leave a note on the release of 1.18.3. More to come later today -- Thanks for surfacing so quickly.