Skip to content

feat: use security-group module instead of resource #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2021
Merged

feat: use security-group module instead of resource #31

merged 1 commit into from
Jun 15, 2021

Conversation

SweetOps
Copy link
Contributor

what

  • use security-group module instead of resource
  • update tests

why

  • more flexible than current implementation
  • bring configuration of security group/rules to one standard

references

  • CPCO-409

@SweetOps SweetOps requested review from a team as code owners May 21, 2021 15:36
@SweetOps SweetOps requested review from Gowiem and 3h4x and removed request for a team May 21, 2021 15:36
@SweetOps SweetOps marked this pull request as draft May 21, 2021 15:36
@SweetOps
Copy link
Contributor Author

/test all

@SweetOps SweetOps marked this pull request as ready for review May 25, 2021 08:06
@nitrocode nitrocode merged commit 0537057 into master Jun 15, 2021
@nitrocode nitrocode deleted the CPCO-409 branch June 15, 2021 19:04
starcry pushed a commit to YouLend/terraform-aws-ec2-instance-group that referenced this pull request Jun 9, 2022
@SweetOps
feat: use security-group module instead of resource (cloudposse#31)
cdb4ca1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@3h4x 3h4x Awaiting requested review from 3h4x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SweetOps @nitrocode