Skip to content

feat: Backport cloudposse/cloudfront-cdn/aws improvements #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

feat: Backport cloudposse/cloudfront-cdn/aws improvements #340

wants to merge 13 commits into from

Conversation

jwadolowski
Copy link
Contributor

what

TBD

why

references

jwadolowski added 12 commits May 13, 2025 17:04
@jwadolowski
chore: Add missing origin_keepalive_timeout and origin_read_timeout v…
6f209dc 
…ariables

Backported from
cloudposse/terraform-aws-cloudfront-cdn#140
@jwadolowski
fix: Configure CORS rules only when there's at least one origin defined
90e3b4c
@jwadolowski
fix: Define sane defaults for module variables
5022a7e
@jwadolowski
fix: Remove redundant lookup() calls
d6f3bc7 
fix: Remove redundant lookup() call
@jwadolowski
fix: Simplify origin_access_control_id assignment
8503795 
The `for_each` inside the `dynamic "s3_origin_config"` block already
checks for `local.origin_access_identity_enabled`, so there's no need to
check it again here.
@jwadolowski
fix: Simplify origin_access_control_id assignment
5d4e833 
The `local.origin_access_control_enabled` value used to be checked
twice; now it's evaluated only once (the logic remains the same).
@jwadolowski
fix: Sync variables.tf defaults with the old lookup() func ones
4e9e3b4
@jwadolowski
fix: Remove more redundant lookup() calls
8faf452 
All variables references by `local.website_config` come with default
values (see `variables.tf`) which make the func call redundant
@jwadolowski
feat: Define sane defaults for ordered_cache variable
199e68f
@jwadolowski
fix: Remove unused versioning_enabled variable
bcdcf11
@jwadolowski
docs: Re-generate docs
b4efb64
@jwadolowski
chore: Add a minimal module instance to the example dir
52c0fc0
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 3, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mergify Mergify
Copy link

mergify bot commented Jun 3, 2025

💥 This pull request now has conflicts. Could you fix it @jwadolowski? 🙏

@mergify mergify bot added conflict This PR has conflicts triage Needs triage labels Jun 3, 2025
@mergify mergify bot removed the conflict This PR has conflicts label Jun 3, 2025
@mergify Mergify
Copy link

mergify bot commented Jun 6, 2025

💥 This pull request now has conflicts. Could you fix it @jwadolowski? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conflict This PR has conflicts triage Needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jwadolowski