fix: Make sure tags are associated with Lambda functions

[jwadolowski]

what

All the tags provided by cloudposse/label/null should be associated with Lambda@Edge functions.

why

tags argument is not set at all which results in an empty tag list.

references

https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/blob/v0.96.1/modules/lambda%40edge/main.tf#L78-L86

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes introduce a new tags attribute in the aws_lambda_function resource definition within the Lambda@Edge module, which is assigned the value from module.function_label[each.key].tags. Additionally, a newline was added to the closing brace of the aws_lambda_permission resource. These modifications do not alter the existing logic, error handling, or control flow.

Changes

File	Change Summary
modules/lambda@edge/main.tf	Added a tags attribute to the aws_lambda_function resource and inserted a newline in the aws_lambda_permission resource closing brace.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f7ed7a and 23b6d7d.

📒 Files selected for processing (1)

• modules/lambda@edge/main.tf (2 hunks)

🧰 Additional context used

🪛 Checkov (3.2.334)

modules/lambda@edge/main.tf

[HIGH] 90-97: Ensure that AWS Lambda function permissions delegated to AWS services are limited by SourceArn or SourceAccount

(CKV_AWS_364)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Summary

🔇 Additional comments (1)

modules/lambda@edge/main.tf (1)

87-88: Tag Assignment Correctness
The new tags attribute in the aws_lambda_function resource correctly associates tags with each Lambda function using module.function_label[each.key].tags. Please ensure that the function_label module reliably outputs a valid tag map for all functions.

🧰 Tools

🪛 Checkov (3.2.334)

[HIGH] 71-88: Ensure AWS Lambda function is configured to validate code-signing

(CKV_AWS_272)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[RoseSecurity]

/terratest

[RoseSecurity]

Looks good to me! Thank you for this contribution

[mergify]

This pull request was automatically closed as it no longer contains any changes.

This typically happens when another merged pull request has already included this request's
proposed modifications into the default branch.

[RoseSecurity]

Some funky GitHub things happened when I merged this. This should be merged and released

[jwadolowski]

@RoseSecurity yup, the PR closure was a bit unexpected ending here 😉 As far as I can see the main branch contains my commit, so it's all good 👍

[RoseSecurity]

@jwadolowski Thanks for understanding. This release contains this update v0.96.2.