Skip to content

Support EFI (and other firmware options) support #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

tpbrisco
Copy link
Contributor

@tpbrisco tpbrisco commented Aug 9, 2024

PR #348 added support for EFI in stemcells versions 1.465 and later.
Virtualbox defaults to BIOS, resulting in unbootable stemcell images.
This change defaults to Virtualbox using EFI64 VMs, and introduces a cloud-config variable to select alternative firmware approaches (or "bios", for compatibility with older stemcells).
No general testing harness seems available; thus testing was done through creating a local CPI release, and going through builds to ascertain that the cloud property propagates through, and yields a working BOSH.

@tpbrisco tpbrisco changed the title Support EFI for VirtualBox Support EFI (and other firmware options) support Aug 9, 2024
Copy link

@jpalermo jpalermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks for the contribution!

Copy link
Member

@xtreme-nitin-ravindran xtreme-nitin-ravindran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpalermo jpalermo merged commit 92ff970 into cloudfoundry:master Aug 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants