Resolve container image name when modifying #9923
Conversation
🦋 Changeset detectedLatest commit: 99ec92b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
gpanders
force-pushed
the
push-nunwqontxqtp
branch
2 times, most recently
from
7ac4444 to
3e3bc9a
Compare
| │ image = \\"${registry}/hello:1.0\\" | ||
| │ image = \\"${registry}/some-account-id/hello:1.0\\" |
There was a problem hiding this comment.
Before, we were also omitting the namespace (account ID) in the diff that we showed to the user. This ends up being more trouble than it's worth, so we include the namespace (account ID) in the diff now. Updated this test to reflect that.
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
| name: "my-container-app", | ||
| instances: 3, | ||
| class_name: "DurableObjectClass", | ||
| image: `${registry}/hello:1.0`, |
There was a problem hiding this comment.
Note: image name does not include namespace (account ID) in Wrangler config here
| account_id: "1", | ||
| scheduling_policy: SchedulingPolicy.REGIONAL, | ||
| configuration: { | ||
| image: `${registry}/some-account-id/hello:1.0`, |
There was a problem hiding this comment.
But in the API, we do include namespace (account ID) in the image name
| ├ EDIT my-container-app | ||
| │ | ||
| │ [containers.configuration] | ||
| │ image = \\"${registry}/some-account-id/hello:1.0\\" |
There was a problem hiding this comment.
And the namespace (account ID) is included in the diff here as well (unmodified).
The container image name should be resolved into the full (namespaced) image name both when creating an application and when modifying an application. Move the image name resolution out of the create path and into the shared code path taken for both creation and modification.
gpanders
force-pushed
the
push-nunwqontxqtp
branch
from
3e3bc9a to
6f02c57
Compare
The container image name should be resolved into the full (namespaced) image name both when creating an application and when modifying an application.
Move the image name resolution out of the create path and into the shared code path taken for both creation and modification.