Skip to content

fix: assets only versions upload should include tag and message #9917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Jul 10, 2025

Fixes CUSTESC-53301.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: static assets changes will not be backported

@edmundhung edmundhung requested a review from a team as a code owner July 10, 2025 12:34
Copy link

changeset-bot bot commented Jul 10, 2025

🦋 Changeset detected

Latest commit: baca938

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main edmundhung/fix-versions-upload-annotation might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9917
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

Copy link

pkg-pr-new bot commented Jul 10, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9917

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9917

miniflare

npm i https://pkg.pr.new/miniflare@9917

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9917

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9917

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9917

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9917

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9917

wrangler

npm i https://pkg.pr.new/wrangler@9917

commit: 03ea04e

@edmundhung edmundhung force-pushed the edmundhung/fix-versions-upload-annotation branch from baca938 to 03ea04e Compare July 10, 2025 12:38
@edmundhung edmundhung added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jul 10, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 10, 2025
"wrangler": patch
---

fix: assets only versions upload should include tag and message
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Just as an FYI, this will also support preview aliases (new!) since they're uploaded in version annotations)

@edmundhung edmundhung merged commit 80cc834 into main Jul 10, 2025
39 of 40 checks passed
@edmundhung edmundhung deleted the edmundhung/fix-versions-upload-annotation branch July 10, 2025 13:18
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants