perf: graduate asset-server binary search experiment to 100% #9908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3291933 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
The improved iterative binary search implementation has been graduated from a 50% experiment to the default implementation. This provides better performance for asset manifest lookups by replacing the recursive binary search with an iterative approach. Changes: - Replace experimental logic in worker.ts with direct usage of improved implementation - Update assets-manifest.ts to use iterative binary search algorithm - Remove experimental files (assets-manifest.2.ts and its test file) - Update tests to work with new implementation signature - Add changeset documenting the performance improvement 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
GregBrimble
force-pushed
the
graduate-asset-server-experiment
branch
from
87a8372 to
a7a6ad8
Compare
vicb
approved these changes
Jul 10, 2025
There was a problem hiding this comment.
LGTM thanks for peparing the PR.
@GregBrimble I have added the PATH_HASH_OFFSET in:
- let entryOffset = HEADER_SIZE + entryIndex * ENTRY_SIZE;
+ let pathHashOffset = HEADER_SIZE + entryIndex * ENTRY_SIZE + PATH_HASH_OFFSET;PATH_HASH_OFFSET === 0 so that's not a behavior change and it is covered by tests.
I added that because:
- It will help if we change the offset at some point (unlikely I guess)
- It better expresses the intent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graduates the asset-server binary search experiment from 50% sampling to 100% usage of the improved implementation.
The iterative binary search algorithm is currently being tested at 50% sample rate to validate its performance compared to the original recursive implementation. This PR prepares the graduation to 100% usage once the experiment proves successful.
Changes
worker.tswith direct usage of improved implementationassets-manifest.tsto use iterative binary search algorithmassets-manifest.2.tsand its test file)Performance Impact
The improved implementation is expected to provide better performance characteristics for asset manifest lookups, which is currently being validated through the 50% experiment rollout.
@vicb This should be merged if the 50% rollout looks good and shows improvement over the original implementation.
🤖 Generated with Claude Code