-
Notifications
You must be signed in to change notification settings - Fork 927
Implements support for python_modules for packages in Python Workers #9905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+71
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 703d498 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
75e914e
to
9a5126f
Compare
danlapid
reviewed
Jul 9, 2025
packages/wrangler/src/deployment-bundle/find-additional-modules.ts
Outdated
Show resolved
Hide resolved
danlapid
reviewed
Jul 9, 2025
packages/wrangler/src/deployment-bundle/find-additional-modules.ts
Outdated
Show resolved
Hide resolved
3663186
to
1384b66
Compare
penalosa
reviewed
Jul 11, 2025
packages/wrangler/src/deployment-bundle/find-additional-modules.ts
Outdated
Show resolved
Hide resolved
c0dac42
to
2320dec
Compare
penalosa
approved these changes
Jul 14, 2025
2320dec
to
703d498
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EW-9326
We don't want the vendored packages to live in src/vendor anymore, instead we want them to be similar to
node_modules
. This PR implements this but retains support for src/vendor for now, with an error being thrown if both directories are present.Test Plan