Skip to content

types: add botManagement.detectionIds to cf.d.ts #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

KianNH
Copy link
Member

@KianNH KianNH commented Feb 3, 2023

Example: ➜ ~ curl https://kian.org.uk/cf.json | jq '.botManagement'

{
  "corporateProxy": false,
  "verifiedBot": false,
  "staticResource": false,
  "detectionIds": [
    33554817
  ],
  "score": 1
}

Example: `➜  ~ curl https://kian.org.uk/cf.json | jq '.botManagement'`

```json
{
  "corporateProxy": false,
  "verifiedBot": false,
  "staticResource": false,
  "detectionIds": [
    33554817
  ],
  "score": 1
}
```
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@KianNH
Copy link
Member Author

KianNH commented Feb 3, 2023

I have read the CLA Document and I hereby sign the CLA

Copy link

@pawel-klim pawel-klim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nit: I would just drop the "in a rule" from the comment since this pertains to workers and not any of the rule-based security tools

@KianNH
Copy link
Member Author

KianNH commented Feb 17, 2023

cc @mrbbot - not sure who else can review types haha

Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! 👋 Thanks for the PR and the ping!

@mrbbot mrbbot merged commit 05c130c into cloudflare:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants