Add wrangler.toml and fix index.js code #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exvuma
commented
Oct 21, 2019
| * @param {Request} request | ||
| */ | ||
| async function handleRequest(request) { | ||
| return new Response('Hello worker!', { status: 200 }) | ||
| return new Response('Hello worker!', { | ||
| headers: { 'content-type': 'text/plain' }, |
There was a problem hiding this comment.
status 200 is the default, so I found that irrelevant. I wanted to include one example of modifying ResponseInit though and it's best praactice to include Content-type anyways so I added that
exvuma
commented
Oct 21, 2019
| @@ -0,0 +1,7 @@ | |||
| name = "helloworld" | |||
| type = "javascript" | |||
There was a problem hiding this comment.
Should we make default webpack instead?
There was a problem hiding this comment.
Probably. It'd also be great to move index.js from the top level and create a src directory and point package.json:main to ./src/index.js
There was a problem hiding this comment.
Ill make an issue for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16
This is the default
wrangler generatetemplate so all nits welcome 😸