sike mitigation with test cases #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armfazh
requested changes
Jun 2, 2022
bwesterb
requested changes
Jun 3, 2022
| // Compute e_3 = log3(2^(nbits+1)) | ||
| var e3 uint32 | ||
| e3_float := float64(int(nbits)+1)/math.Log2(3) | ||
| e3 = uint32(e3_float) |
There was a problem hiding this comment.
Maybe nicer to have e3 as a constant in SidhParams instead of recomputing.
There was a problem hiding this comment.
Having e3 as a parameter requires me to change the params.go
I want to put changes in the test files as much as possible.
Do you think I should touch the params.go?
There was a problem hiding this comment.
e3 is definitely a constant, however, its calculation is simple and used once.
We may revisit later moving this value to the params files.
zhdllwyc
force-pushed
the
sike-mitigation
branch
2 times, most recently
from
9ca8a3e to
005359c
Compare
armfazh
requested changes
Jun 3, 2022
armfazh
approved these changes
Jun 3, 2022
bwesterb
reviewed
Jun 4, 2022
| @@ -260,7 +261,7 @@ func DeriveSecretA(ss, prv []byte, pub3Pt *[3]Fp2) { | |||
| } | |||
|
|
|||
| // Establishing shared keys in in 3-torsion group | |||
| func DeriveSecretB(ss, prv []byte, pub3Pt *[3]Fp2) { | |||
| func DeriveSecretB(ss, prv []byte, pub3Pt *[3]Fp2) { | |||
bwesterb
approved these changes
Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.