Skip to content

fix:change in count condition #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 22, 2024
Merged

fix:change in count condition #16

merged 5 commits into from
Feb 22, 2024

Conversation

Rupalgw
Copy link
Contributor

@Rupalgw Rupalgw commented Feb 19, 2024

what

• Test each module when the enable variable is true.
• Deploy the module, then set the enable variable to false, ensuring all resources are destroyed without errors.

why

*the changes being made due to error in count condition

@Rupalgw Rupalgw added the enhancement New feature or request label Feb 19, 2024
@Rupalgw Rupalgw requested review from 13archit and d4kverma February 19, 2024 12:52
@Rupalgw Rupalgw self-assigned this Feb 19, 2024
@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 CRITICAL Data factory allows public network access. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:34
────────────────────────────────────────────────────────────────────────────────
   29    resource "azurerm_data_factory" "factory" {
   ..  
   34  [   public_network_enabled          = var.public_network_enabled (true)
   ..  
   53    }
────────────────────────────────────────────────────────────────────────────────
          ID azure-datafactory-no-public-access
      Impact Data factory is publicly accessible
  Resolution Set public access to disabled for Data Factory

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/azure/datafactory/no-public-access/
  - https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/data_factory#public_network_enabled
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             67.005µs
  parsing              78.880482ms
  adaptation           109.184µs
  checks               3.669582ms
  total                82.726253ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     44
  files read           4

  results
  ──────────────────────────────────────────
  passed               0
  ignored              0
  critical             1
  high                 0
  medium               0
  low                  0

  1 potential problem(s) detected.

main.tf Outdated
@@ -26,6 +26,7 @@ resource "random_string" "random" {
}
}

# tfsec:ignore:azure-datafactory-no-public-access
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we are adding this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does tfsec fail if we don't add this?

@13archit 13archit merged commit 7d21464 into master Feb 22, 2024
@delete-merged-branch delete-merged-branch bot deleted the fix/count branch February 22, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants