Skip to content

Fixed Module Code and Removed Depriciated Values #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 9, 2025
Merged

Fixed Module Code and Removed Depriciated Values #14

merged 15 commits into from
Jan 9, 2025

Conversation

vedkops
Copy link
Contributor

@vedkops vedkops commented Sep 17, 2024 •
edited
Loading

What :

  • Created version.tf in example folder
  • Added Subscription ID in Provider Block
  • Updated Terraform Version from 2.9.0 to 3.112.0
  • Updated GitHub Workflows with the latest one
  • Removed variables that are not used in the code and also updated variable type where not defined

Why :

  • Attribute were Depreciated when tested on Latest Version
  • version.tf was not specified in example folder
  • variables were declared but not used

@clouddrove-ci clouddrove-ci self-assigned this Sep 17, 2024
13archit
13archit requested changes Sep 18, 2024
View reviewed changes
Copy link
Member

@13archit 13archit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example folder names should be examples.

@vedkops vedkops requested a review from 13archit September 18, 2024 10:09
13archit
13archit reviewed Sep 24, 2024
View reviewed changes
13archit
13archit reviewed Sep 24, 2024
View reviewed changes
@vedkops vedkops requested a review from 13archit September 24, 2024 13:52
@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output 



      		
    

  





        


            

            
            

              
            

        

      


      

            
  

    
  
    
    

  

  


    












      

  
        





      

  
          

  
  

  
      @13archit
  13archit


          self-requested a review


    October 4, 2024 10:56    
    









      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            
            

              
            

        

      


      

            
  

    
  
    
    

  

  


    












      

  
            

    

      
    

    


      

          @vedkops
vedkops




          added
  the 

  enhancement

  New feature or request
 label


      Dec 20, 2024

    

  



  

  

    
  

  


        
        @d4kverma
  d4kverma



        merged commit 21f76f0
      into

      
  
    master
  


    Jan 9, 2025

      

        10 checks passed
      


      

        
          
  
    
    

      

  
















  
  

    

      

  




      

    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    

  

    Reviewers
  


    


      

          

  
      @d4kverma
  
    d4kverma


                Awaiting requested review from d4kverma


        
      

      

          

  
      @13archit
  
    13archit


                Awaiting requested review from 13archit


        
      


      






    

  


      
  

    Assignees
  



        

      

        

  
      @clouddrove-ci
  
    clouddrove-ci
    

      








      


  


  

    Labels
  



    

      

    enhancement

  New feature or request








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  



            


Successfully merging this pull request may close these issues.



  


      
    

  




      

    

  
      

  

    

      4 participants
    

    

        
          @vedkops 
        
          @clouddrove-ci 
        
          @13archit 
        
          @d4kverma