Skip to content

fix- hardcoded value #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 21, 2023
Merged

fix- hardcoded value #28

merged 5 commits into from
Nov 21, 2023

Conversation

Kasarpooja
Copy link
Contributor

what

  • updated hardcode value in main file.
    image

@Kasarpooja Kasarpooja requested a review from a team November 20, 2023 18:28
@clouddrove-ci clouddrove-ci self-assigned this Nov 20, 2023
@Kasarpooja Kasarpooja self-assigned this Nov 20, 2023
@Kasarpooja Kasarpooja added WIP Work In Progress Under Review Changes being reviewed by reviewers bug Something isn't working and removed WIP Work In Progress labels Nov 20, 2023
h1manshu98
h1manshu98 previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@h1manshu98 h1manshu98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Reviewing below commits.

omsharma07
omsharma07 previously approved these changes Nov 20, 2023
View reviewed changes
Copy link

@omsharma07 omsharma07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kasarpooja Kasarpooja dismissed stale reviews from omsharma07 and h1manshu98 via 8a63d7f November 21, 2023 10:21
@h1manshu98 h1manshu98 self-requested a review November 21, 2023 12:24
h1manshu98
h1manshu98 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@h1manshu98 h1manshu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

omsharma07
omsharma07 approved these changes Nov 21, 2023
View reviewed changes
Copy link

@omsharma07 omsharma07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omsharma07 omsharma07 merged commit 829161f into master Nov 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/hardcoded-values branch November 21, 2023 13:50
@Kasarpooja Kasarpooja added Done and removed bug Something isn't working Under Review Changes being reviewed by reviewers labels Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omsharma07 omsharma07 omsharma07 approved these changes

@h1manshu98 h1manshu98 h1manshu98 approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

@theprashantyadav theprashantyadav Awaiting requested review from theprashantyadav

@mamrajyadav mamrajyadav Awaiting requested review from mamrajyadav

Assignees

@clouddrove-ci clouddrove-ci

@Kasarpooja Kasarpooja

Labels
Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kasarpooja @omsharma07 @h1manshu98 @clouddrove-ci