Remove C package #1685
Merged
Remove C package #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ECL, the C package is the compiler package. But it may be used as a nickname by other systems and cause a collision. Also, nothing actually seems to use cmpname, the only file using the package. It was added in df8b9a5 for ASDF, but ASDF removed the use of compute-init-name a few months earlier, and does not appear to have ever used our compute-init-name, so I don't know what's up with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ECL, the C package is the compiler package. But it may be used as a nickname by other systems and cause a collision. Also, nothing actually seems to use cmpname, the only file using the package. It was added in df8b9a5 for ASDF, but ASDF removed the use of compute-init-name a few months earlier, and does not appear to have ever used our compute-init-name, so I don't know what's up with that.