Skip to content

Issue 558 #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2016
Merged

Issue 558 #560

merged 4 commits into from
Jul 1, 2016

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Jul 1, 2016

No description provided.

kbknapp added 3 commits July 1, 2016 13:47
…hould be with this setting

Prior to this fix, using `AppSettings::AllowLeadingHyphen` wouldn't properly ignore `--`

Closes #558
@yo-bot
Copy link

yo-bot commented Jul 1, 2016

r? @sru

(yo-bot has picked a reviewer for you, use r? to override)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 82.231% when pulling aa95719 on issue-558 into 70fa5f7 on master.

@kbknapp
Copy link
Member Author

kbknapp commented Jul 1, 2016

@homu r+

@homu
Copy link
Contributor

homu commented Jul 1, 2016

📌 Commit aa95719 has been approved by kbknapp

homu added a commit that referenced this pull request Jul 1, 2016
@homu
Copy link
Contributor

homu commented Jul 1, 2016

⌛ Testing commit c9d1739 with merge 16cd48e...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 82.231% when pulling c9d1739 on issue-558 into 453cff5 on master.

@homu
Copy link
Contributor

homu commented Jul 1, 2016

☀️ Test successful - status

@kbknapp
Copy link
Member Author

kbknapp commented Jul 1, 2016

@homu retry

@kbknapp kbknapp merged commit f10375e into master Jul 1, 2016
@kbknapp kbknapp deleted the issue-558 branch July 3, 2016 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants