Feature: Introduce bind().toMany() binding chain in ObservableMixin.
#225
Conversation
| // @param {String} attribute | ||
| // @returns {Array.<String>} | ||
| function getBindingTargets( observables, attribute ) { | ||
| return Array.prototype.concat( ...observables.map( observable => [ observable, attribute ] ) ); |
There was a problem hiding this comment.
Can't it be just that:
return observables.map( observable => [ observable, attribute ] );There was a problem hiding this comment.
It seems so. I admit that I haven't even looked at the code ;)
There was a problem hiding this comment.
Ah, no. It needs to be a concat() call. Because it takes [1,2],[3,4],... arrays and returns [1,2,3,4...]. Am I right, @jodator?
There was a problem hiding this comment.
Hmm, after short analyzing I've found that it might be correct as the result of this fn is [ observable1, attribute, observable2, attribute ... ].
But docs are incorrect here anyway, observables can't be here iterable and the return type is different.
There was a problem hiding this comment.
Yeah - return type should be Array.<Observable|String> as the result is as @ma2ciek wrote.
Suggested merge commit message (convention)
Type: Feature: Introduce
bind().toMany()binding chain inObservableMixin. Closes ckeditor/ckeditor5#4994.