This repository was archived by the owner on Jun 26, 2020. It is now read-only.
t/24: Added separators to the table UI drop-downs #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 12, 2018
|
Hm... Since we don't have the switch yet, adding that separator has a side-effect – it now looks as if the dropdown's panel had a header which says "Header column" :D |
jodator
approved these changes
Jun 12, 2018
There was a problem hiding this comment.
LGTM. I had only some doubts in dependent issue in UI. When the ckeditor/ckeditor5-ui#407 will be closed this might be as well :).
|
Ready for another round of review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Added separators to the table UI drop-downs. Closes ckeditor/ckeditor5#3178.
Additional information
Requires: