Skip to content

Downgrade @rollup/plugin-typescript to version 12.1.2 to fix failing builds #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

filipsobol
Copy link
Member

@CKEditorBot
Copy link
Collaborator

CKEditorBot commented Jun 18, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@coveralls
Copy link

Coverage Status

coverage: 86.688%. remained the same
when pulling 2a54f8e on ck/18731-downgrade-rollup-plugin-typescript
into eb21b77 on master.

@pomek
Copy link
Member

pomek commented Jun 18, 2025

  • #master

     Exit code: 1
     Command: node ./scripts/postinstall.js
     Arguments:
     Directory: /home/pomek/Projects/ckeditor/ckeditor5/node_modules/ckeditor5-dev
     Output:
     > @ckeditor/[email protected] postinstall
     > node bin/postinstall.js
     
     Building: "@ckeditor/ckeditor5-dev-utils"...
     
     > @ckeditor/[email protected] build
     > rollup -c rollup.config.js
     
     
     src/index.ts, src/loaders/ck-debug-loader.ts → dist...
     [!] RollupError: src/loaders/getdebugloader.ts (6:9): "fileURLToPath" is not exported by "../../../../node_modules/url/url.js", imported by "src/loaders/getdebugloader.ts".
     https://rollupjs.org/troubleshooting/#error-name-is-not-exported-by-module
     src/loaders/getdebugloader.ts (6:9)
     4:  */
     5: import path from 'path';
     6: import { fileURLToPath } from 'url';
                 ^
     7: const __filename = fileURLToPath(import.meta.url);
     8: const __dirname = path.dirname(__filename);
         at getRollupError (/home/pomek/Projects/ckeditor/ckeditor5/node_modules/rollup/dist/shared/parseAst.js:285:41)
         at Object.error (/home/pomek/Projects/ckeditor/ckeditor5/node_modules/rollup/dist/shared/parseAst.js:281:42)
         at Module.error (/home/pomek/Projects/ckeditor/ckeditor5/node_modules/rollup/dist/shared/rollup.js:18409:28)
         at Module.traceVariable (/home/pomek/Projects/ckeditor/ckeditor5/node_modules/rollup/dist/shared/rollup.js:18858:29)
         at ModuleScope.findVariable (/home/pomek/Projects/ckeditor/ckeditor5/node_modules/rollup/dist/shared/rollup.js:16518:39)
         at Identifier.bind (/home/pomek/Projects/ckeditor/ckeditor5/node_modules/rollup/dist/shared/rollup.js:9190:40)
         at CallExpression.bind (/home/pomek/Projects/ckeditor/ckeditor5/node_modules/rollup/dist/shared/rollup.js:6581:23)
         at CallExpression.bind (/home/pomek/Projects/ckeditor/ckeditor5/node_modules/rollup/dist/shared/rollup.js:13603:15)
         at VariableDeclarator.bind (/home/pomek/Projects/ckeditor/ckeditor5/node_modules/rollup/dist/shared/rollup.js:6581:23)
         at VariableDeclaration.bind (/home/pomek/Projects/ckeditor/ckeditor5/node_modules/rollup/dist/shared/rollup.js:6577:28)
    
  • Changes from the PR:

     > @ckeditor/[email protected] postinstall
     > node bin/postinstall.js
     
     Building: "@ckeditor/ckeditor5-dev-utils"...
     
     > @ckeditor/[email protected] build
     > rollup -c rollup.config.js
     
     
     src/index.ts, src/loaders/ck-debug-loader.ts → dist...
     created dist in 1s
     Building: "@ckeditor/typedoc-plugins"...
     
     > @ckeditor/[email protected] build
     > rollup -c rollup.config.js
     
     
     src/index.ts → dist...
     created dist in 1.2s
     Building: "@ckeditor/ckeditor5-dev-web-crawler"...
     
     > @ckeditor/[email protected] build
     > rollup -c rollup.config.js
     
     
     src/index.ts → dist...
     created dist in 1.1s
     Building: "@ckeditor/ckeditor5-dev-changelog"...
     
     > @ckeditor/[email protected] build
     > rollup -c rollup.config.js
     
     
     src/index.ts → dist/index.js...
     created dist/index.js in 1.3s
     
     src/template.ts → dist/template.js...
     created dist/template.js in 927ms
     Building: "@ckeditor/ckeditor5-dev-build-tools"...
     
     > @ckeditor/[email protected] build
     > rollup -c rollup.config.js
    

Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@filipsobol filipsobol merged commit ccf6a79 into master Jun 18, 2025
11 checks passed
@filipsobol filipsobol deleted the ck/18731-downgrade-rollup-plugin-typescript branch June 18, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing CI caused by @rollup/plugin-typescript
4 participants