Skip to content

Fix existing E2E test failures and Improve resource cleanup #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 9, 2025
Merged

Fix existing E2E test failures and Improve resource cleanup #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ad8a05d
fix: upgrade civogo and bugfix useragent settings
hlts2 Apr 2, 2025
a238dbe
fix: bugfix and todo comment
hlts2 Apr 2, 2025
7198c0d
fix: add region to ip request
hlts2 Apr 2, 2025
2c1246a
fix: deleted unnecessary code
hlts2 Apr 2, 2025
693b35d
fix: add resource cleanup logic
hlts2 Apr 3, 2025
01fd65c
fix: use cleanup function
hlts2 Apr 7, 2025
9acf100
fix: revert variable changes
hlts2 Apr 7, 2025
55d0d20
fix: deleted unnecessary test
hlts2 Apr 7, 2025
a69ce30
fix: add test error handling
hlts2 Apr 7, 2025
f7a2e61
Revert "fix: add test error handling"
hlts2 Apr 7, 2025
e0b31c5
fix: add timeout context
hlts2 Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ e2e tests for the Civo Cloud Controller Manager.
These tests can be run:

```bash
CIVO_API_KEY=.... go test --timeout 30 -v ./e2e/...
CIVO_API_KEY=.... go test -timeout 20m -v ./...
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

The command was incorrect, so I have fixed it. Additionally, since it didn't finish within 30 seconds, I have changed the timeout to 20 minutes.

```

or the CIVO_API_KEY can be set in the `.env` file in the root of the project
Expand All @@ -21,7 +21,7 @@ The general flow for each test is as follows:
1. Provision a new cluster
2. Wait for the cluster to be provisioned
2. Scale down pre-deployed CCM in the cluster
4. Run the local copy of CCM
4. Run the local copy of CCM
5. Run e2e Tests
6. Delete the cluster

Expand Down
Loading