Skip to content

package: Fix wrong repository URL syntax #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2018
Merged

package: Fix wrong repository URL syntax #160

merged 1 commit into from
Jan 30, 2018

Conversation

sschuberth
Copy link
Contributor

If using the scp-like Git URL syntax [1], a colon (':') must be used
after the server part. Better not use that syntax anyway but the
more common HTTP protocol, which also is GitHub's default.

[1] https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols#_the_ssh_protocol

If using the scp-like Git URL syntax [1], a colon (':') must be used
after the server part. Better not use that syntax anyway but the
more common HTTP protocol, which also is GitHub's default.

[1] https://git-scm.com/book/en/v2/Git-on-the-Server-The-Protocols#_the_ssh_protocol
sschuberth added a commit to oss-review-toolkit/ort that referenced this pull request Jan 30, 2018
sschuberth added a commit to oss-review-toolkit/ort that referenced this pull request Jan 30, 2018
sschuberth added a commit to oss-review-toolkit/ort that referenced this pull request Jan 30, 2018
@linuxwolf linuxwolf self-requested a review January 30, 2018 16:39
Copy link
Member

@linuxwolf linuxwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@linuxwolf linuxwolf merged commit 0e4dcba into cisco:master Jan 30, 2018
@sschuberth sschuberth deleted the patch-1 branch January 30, 2018 16:40
@sschuberth
Copy link
Contributor Author

@linuxwolf, FYI, this was catched by https://github.com/heremaps/oss-review-toolkit 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants