Skip to content

Configure namespace.h into cmake binary dir instead of source #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

Atlante45
Copy link
Contributor

When calling configure_file() on namespace.h.in, cmake will create a temporary file at the target location called namespace.h.tmp and when done generating move it to namespace.h

This causes an issue when building multiple release types at the same time. They will both generate the same .tmp file and overwrite each other. The first that completes will move the shared file causing the other instance to fail with the error No such file or directory

This is a proposed solution that generates the namespace header in the binary directory as intended by configure_file and then makes sure all relevant steps load the header from the appropriate directory

Verified

This commit was signed with the committer’s verified signature.
bmwiedemann Bernhard M. Wiedemann
@bifurcation bifurcation mentioned this pull request Apr 24, 2025
Copy link
Contributor

@bifurcation bifurcation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Atlante45, and sorry for the very delayed review.

FYI, I filed #448 with a couple of minor follow-ups, so as not to delay merging this.

@bifurcation
Copy link
Contributor

I'm not sure why CI is not running on this. Merging on faith, and verifying later.

@bifurcation bifurcation merged commit 7ca371f into cisco:main Apr 24, 2025
bifurcation added a commit that referenced this pull request Apr 24, 2025
bifurcation added a commit that referenced this pull request Apr 24, 2025
* Follow-ups from #439

* Follow-up from #443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants