Expose runner environment variables to gitlab-runner installation script #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UiP9AV6Y
force-pushed
the
prepare-install-env
branch
from
a00957c to
3aad91f
Compare
* merge the various installation scripts into a single one * use text/template to render the actual script based on user/operator input * implement unit tests for test coverage of new feature closes cirruslabs#111
UiP9AV6Y
force-pushed
the
prepare-install-env
branch
from
3aad91f to
9a3b4dd
Compare
|
Hello Gordon, It looks like this PR includes more changes than necessary to address #111. This makes the review process more difficult and leads to unnecessary discussions about the additional changes. A minimal, focused diff would be greatly appreciated. |
UiP9AV6Y
added a commit
to UiP9AV6Y/gitlab-tart-executor
that referenced
this pull request
Apr 25, 2025
this change replaces the embedded gitlab-runner installer scripts with a template which is rendered as a shell script based on cli/env configuration. the feature is inteded as preparation for cirruslabs#113
UiP9AV6Y
added a commit
to UiP9AV6Y/gitlab-tart-executor
that referenced
this pull request
Apr 25, 2025
both gitlab.EnvPrefixGitLabRunner and tart.EnvPrefixTartExecutor are public now for consistency sake. initializing the tart configuration requires passing a key prefix, which is usually gitlab.EnvPrefixGitLabRunner providing the prefix ensures the gitlab and tart namespace remain independent. this change is in preparation for cirruslabs#113
UiP9AV6Y
added a commit
to UiP9AV6Y/gitlab-tart-executor
that referenced
this pull request
Apr 25, 2025
both gitlab.EnvPrefixGitLabRunner and tart.EnvPrefixTartExecutor are public now for consistency sake. initializing the tart configuration requires passing a key prefix, which is usually gitlab.EnvPrefixGitLabRunner providing the prefix ensures the gitlab and tart namespace remain independent. this change is in preparation for cirruslabs#113
UiP9AV6Y
added a commit
to UiP9AV6Y/gitlab-tart-executor
that referenced
this pull request
Apr 25, 2025
both gitlab.EnvPrefixGitLabRunner and tart.EnvPrefixTartExecutor are public now for consistency sake. initializing the tart configuration requires passing a key prefix, which is usually gitlab.EnvPrefixGitLabRunner. providing the prefix ensures the gitlab and tart namespace remain independent. additionally a proxy method for os.LookupEnv has been implemented utilizing the newly added constant as prefix for variable lookups. this change is in preparation for cirruslabs#113
This was referenced Apr 26, 2025
sure thing. have you identified areas which could be broken out into separate MRs? i have already prepared two changes. |
Please take a look at #116. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #111