Avoid transitive dependency on github.com/miekg/dns in policy API #16806
+142
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
the
release-note/misc
tklauser
force-pushed
the
pr/dns-break-dependency
branch
from
8d790a0 to
78facc1
Compare
|
test-me-please |
jrajahalme
approved these changes
Jul 7, 2021
|
timing out ci-gke should be fixed by #16819 |
tklauser
force-pushed
the
pr/dns-break-dependency
branch
from
78facc1 to
a98f9a3
Compare
|
Rebased to pick up fixes for the failing CI 3.0 tests. |
|
test-me-please |
nathanjsweet
requested changes
Jul 9, 2021
borkmann
approved these changes
Jul 12, 2021
tklauser
force-pushed
the
pr/dns-break-dependency
branch
from
a98f9a3 to
24baed3
Compare
|
test-me-please |
tklauser
force-pushed
the
pr/dns-break-dependency
branch
from
24baed3 to
ecf14a2
Compare
|
test-me-please |
The github.com/cilium/cilium/pkg/fqdn/dns duplicates the IsFqdn and Fqdn functions from github.com/miekg/dns. This allows to avoid a transitive dependency on the latter package for users of the policy API, namely github.com/cilium/cilium-cli. While at it, rename the functions such that they conform to the Go naming standard and also make func FQDN return a lowercase string, as expected by all callers in Cilium code. Signed-off-by: Tobias Klauser <[email protected]>
…kage Avoid pulling in github.com/miekg/dns as a transitive dependency for out-of-tree users of the Cilium API, namely github.com/cilium/cilium-cli. Signed-off-by: Tobias Klauser <[email protected]>
tklauser
force-pushed
the
pr/dns-break-dependency
branch
from
ecf14a2 to
a45b199
Compare
|
test-me-please Rebased to pull in the fix for #16632 |
tklauser
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new helper package duplicating
IsFqdnandFqdnfrom theg.yxqyang.asia/miekg/dnsto avoid transitively depending on that package in out-of-tree users of the policy API, namelyg.yxqyang.asia/cilium/cilium-cli. This will e.g. allow to fix cilium/cilium-cli#231.See individual commits for details.