Skip to content

prepare for branching v0.1 #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented May 31, 2024

For context, #220 will introduce a configuration breaking change and after discussion we will maintain patch release v0.1 branch for Cilium < v1.16.

.github/workflows/build-images-release.yaml is based on tags and thus should work without modifications. I'm also inclined to change the default branch to main instead of the current master for consistency with other cilium repository (see cilium/cilium#23110).

@kaworu kaworu added documentation Improvements or additions to documentation enhancement New feature or request github_actions Pull requests that update Github_actions code labels May 31, 2024
@kaworu kaworu requested a review from giorio94 May 31, 2024 12:11
@kaworu kaworu self-assigned this May 31, 2024
@kaworu kaworu requested review from a team as code owners May 31, 2024 12:11
@kaworu kaworu requested review from viktor-kurchenko and rolinh and removed request for a team May 31, 2024 12:11
Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rolinh
Copy link
Member

rolinh commented May 31, 2024

Why do we want to maintain a v0.1 branch with patch releases vs updating to v0.2 in stable branches of Cilium? What are our main concerns?

I'm wary of adding more maintenance work to our shoulders. Admittedly, updating the Cilium charts to use v0.2 is a one time effort that we can backport to stable branches whereas maintaining and publishing new releases for 2 branches is work that will have to be carried out until v1.15 is EOL.

@giorio94
Copy link
Member

giorio94 commented Jun 4, 2024

Why do we want to maintain a v0.1 branch with patch releases vs updating to v0.2 in stable branches of Cilium? What are our main concerns?

From my point of view, the main concern would be the possible introduction of regressions, mainly during the backport of the helm changes to stable branches. Different branches have slight differences, and CI coverage is a bit lacking in that respect AFAIK (I've recently modified the clustermesh tests to also leverage certgen, but for instance I don't think we validate the hubble certs anywhere explicitly in those workflows -- especially relay/ui ones).

@kaworu
Copy link
Member Author

kaworu commented Jun 4, 2024

Why do we want to maintain a v0.1 branch with patch releases vs updating to v0.2 in stable branches of Cilium? What are our main concerns?

As @giorio94 pointed out regression is the main concern, but also it's unclear to me whether the overhead of maintaining v0.1 will be that much higher than porting v0.2 to stables branches.

Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's go for it then.

@kaworu kaworu merged commit da945af into master Jun 5, 2024
1 check passed
@kaworu kaworu deleted the pr/kaworu/prepare-for-branching-v0.1 branch June 5, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants