Skip to content

Consistent search experience #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Consistent search experience #1752

wants to merge 5 commits into from

Conversation

alex-ju
Copy link
Contributor

@alex-ju alex-ju commented Mar 19, 2024

Summary

In this PR we propose a consistent search experience across the two main variations (single-selection and multi-selection). While I appreciate this would create a breaking change, and comes with tradeoffs, I believe it's worth exploring this not only for a unified search experience but also to reduce the code and maintainability required for two search experiences.

If maintainers are interested in considering this approach I can investigate the implications of such change more exhaustively.

Current experience with @searchEnabled={{true}}

Single-selectionMulti-selection
01 power-select-search 02 power-select-multiple-before

Proposed experience with @searchEnabled={{true}}

Single-selectionMulti-selection
01 power-select-search 04 power-select-multiple-after

Examples

The example below uses the helpers-testing-single-power-select instance in the test-app.

BeforeAfter
02 power-select-multiple-before 04 power-select-multiple-after
03 power-select-multiple-before 05 power-select-multiple-after

@mkszepp
Copy link
Collaborator

mkszepp commented Mar 20, 2024

Hi @alex-ju thanks for this draft... i think it very good to align single & multiple. As you have described this is braking.

What do you thing about making an option like @searchFieldPosition (default | inline).
In v8 we can set for the single dropdown @searchFieldPosition = 'default' as default and for multiple @searchFieldPosition = 'inline'.

So we can bring this feature already in v8 and in next major update we do align this option.
Of course we need also to extend the single select field with inline option like in https://react-select.com/home#welcome

@alex-ju
Copy link
Contributor Author

alex-ju commented Mar 20, 2024

Hi @alex-ju thanks for this draft... i think it very good to align single & multiple. As you have described this is braking.

What do you thing about making an option like @searchFieldPosition (default | inline). In v8 we can set for the single dropdown @searchFieldPosition = 'default' as default and for multiple @searchFieldPosition = 'inline'.

So we can bring this feature already in v8 and in next major update we do align this option. Of course we need also to extend the single select field with inline option like in https://react-select.com/home#welcome

That sounds like a good plan for a transition – and we can decide later if we want to keep both or not. Thanks for the feedback – I will likely close this one and open one that introduces @searchFieldPosition

@alex-ju alex-ju closed this Mar 20, 2024
@alex-ju alex-ju deleted the alex-ju/consistent-search branch March 20, 2024 18:46
@mkszepp
Copy link
Collaborator

mkszepp commented Mar 21, 2024

great thanks! For position values maybe we can find something better... maybe before-options / trigger or if you have a better idea, feel free to define

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants