⏰ Add td_*seconds serde Serialize and Deserialize functions for TimeDelta
#1652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tosti007
changed the title
td_*seconds serde Serialize and Deserialize functions for TimeDeltatd_*seconds serde Serialize and Deserialize functions for TimeDelta
djc
reviewed
Jan 17, 2025
|
I can't wait for this PR to be merged! |
Thanks for the ping, I totally forgot about this. I'll see if I can get it in a good state somewhere this week. |
tosti007
force-pushed
the
tosti007/td-seconds
branch
from
f14cedd to
8432de8
Compare
tosti007
force-pushed
the
tosti007/td-seconds
branch
from
8432de8 to
9abf81e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
==========================================
- Coverage 90.59% 90.26% -0.33%
==========================================
Files 38 38
Lines 16028 16463 +435
==========================================
+ Hits 14520 14860 +340
- Misses 1508 1603 +95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
djc
reviewed
May 30, 2025
tosti007
force-pushed
the
tosti007/td-seconds
branch
from
8de35ba to
ce66b33
Compare
|
I see codecov says no, I haven't really used that before. Does that mean it just requires more tests which touch the added codepaths? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117
This PR copy-pastes the current implementation for
DateTimesuch that we have equal implementations forDeltaTime.I opted to add the logic to the existing
serde.rsfile. However, I think this might be the wrong place and a better solution would be to move themain.rs'sserdemodule combined with thisserde.rsfile to a separatesrc/serde.rsfile, thoughts?PS:
I am just doing a drive-by PR on this crate, so I don't really know what the exact requirements are regarding testing ect. Please let me know!