Skip to content

Fix VSIX build workflows by switching from dotnet restore to msbuild restore #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 8, 2025

The VSIX build workflows were failing because dotnet restore doesn't properly set up the Visual Studio SDK build tools required for VSIX projects. This PR applies the same fix that resolved the identical issue in the apiclientcodegen repository.

Changes Made

.github/workflows/vsix.yml

  • Moved "Setup MSBuild.exe" step before "Restore" step
  • Changed dotnet restore VSIX.sln to msbuild VSIX.sln -t:Restore
  • Updated microsoft/[email protected] to microsoft/setup-msbuild@v2

.github/workflows/release-vsix.yml

  • Applied the same changes as above for consistency

Root Cause

When using dotnet restore for VSIX projects, the Microsoft Visual Studio SDK build tools don't get properly restored, leading to missing target files like Microsoft.VsSDK.targets that are essential for the VSIX build process. The msbuild -t:Restore command ensures these tools are correctly set up.

Testing

These changes follow the exact same pattern that successfully fixed the identical issue in the referenced repository, ensuring consistency and reliability. The workflow order change ensures MSBuild is available before attempting to restore packages.

Fixes #210.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] VSIX build is failing Fix VSIX build workflows by switching from dotnet restore to msbuild restore Jun 8, 2025
@Copilot Copilot AI requested a review from christianhelle June 8, 2025 06:11
Copilot finished work on behalf of christianhelle June 8, 2025 06:11
Copy link

sonarqubecloud bot commented Jun 8, 2025

@christianhelle christianhelle marked this pull request as ready for review June 8, 2025 06:55
@Copilot Copilot AI review requested due to automatic review settings June 8, 2025 06:55
Copy link

coderabbitai bot commented Jun 8, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes build failures in VSIX projects by switching the restore process from dotnet to msbuild, ensuring the Visual Studio SDK build tools are properly set up. Key changes include:

  • Moving the "Setup MSBuild.exe" step before the "Restore" step.
  • Replacing the "dotnet restore" command with "msbuild VSIX.sln -t:Restore" in both workflows.
  • Upgrading the MSBuild setup action from v1.3 to v2 for consistency and improved compatibility.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/vsix.yml Updated the restore command and MSBuild setup order to ensure correct SDK tool setup.
.github/workflows/release-vsix.yml Applied similar updates as in vsix.yml for consistency across workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSIX build is failing
2 participants