-
-
Notifications
You must be signed in to change notification settings - Fork 9
Fix VSIX build workflows by switching from dotnet restore to msbuild restore #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: christianhelle <[email protected]>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes build failures in VSIX projects by switching the restore process from dotnet to msbuild, ensuring the Visual Studio SDK build tools are properly set up. Key changes include:
- Moving the "Setup MSBuild.exe" step before the "Restore" step.
- Replacing the "dotnet restore" command with "msbuild VSIX.sln -t:Restore" in both workflows.
- Upgrading the MSBuild setup action from v1.3 to v2 for consistency and improved compatibility.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
.github/workflows/vsix.yml | Updated the restore command and MSBuild setup order to ensure correct SDK tool setup. |
.github/workflows/release-vsix.yml | Applied similar updates as in vsix.yml for consistency across workflows. |
The VSIX build workflows were failing because
dotnet restore
doesn't properly set up the Visual Studio SDK build tools required for VSIX projects. This PR applies the same fix that resolved the identical issue in the apiclientcodegen repository.Changes Made
.github/workflows/vsix.yml
dotnet restore VSIX.sln
tomsbuild VSIX.sln -t:Restore
microsoft/[email protected]
tomicrosoft/setup-msbuild@v2
.github/workflows/release-vsix.yml
Root Cause
When using
dotnet restore
for VSIX projects, the Microsoft Visual Studio SDK build tools don't get properly restored, leading to missing target files likeMicrosoft.VsSDK.targets
that are essential for the VSIX build process. Themsbuild -t:Restore
command ensures these tools are correctly set up.Testing
These changes follow the exact same pattern that successfully fixed the identical issue in the referenced repository, ensuring consistency and reliability. The workflow order change ensures MSBuild is available before attempting to restore packages.
Fixes #210.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.