Skip to content

Add a new field type: AsymmetricRelatedField #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion rest_framework_extensions/fields.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
from rest_framework.relations import HyperlinkedRelatedField
from rest_framework.relations import HyperlinkedRelatedField, PrimaryKeyRelatedField

from rest_framework import serializers


class ResourceUriField(HyperlinkedRelatedField):
Expand Down Expand Up @@ -26,3 +28,14 @@ class Meta:
def __init__(self, *args, **kwargs):
kwargs.setdefault('source', '*')
super().__init__(*args, **kwargs)


class AsymmetricRelatedField(serializers.PrimaryKeyRelatedField):
def __init__(
self, serializer_class, *args, **kwargs
) -> None:
self.serializer_class = serializer_class
super().__init__(*args, **kwargs)

def to_representation(self, value):
return self.serializer_class(value).data
Empty file.
10 changes: 10 additions & 0 deletions tests_app/tests/unit/fields/models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
from django.db import models


class RelatedModel(models.Model):
name = models.CharField(max_length=100)


class SomeModel(models.Model):
name = models.CharField(max_length=100)
related_model = models.ForeignKey(RelatedModel, on_delete=models.CASCADE)
21 changes: 21 additions & 0 deletions tests_app/tests/unit/fields/serializers.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
from rest_framework import serializers
from rest_framework_extensions.fields import AsymmetricRelatedField

from .models import SomeModel, RelatedModel


class RelatedModelSerializer(serializers.ModelSerializer):
class Meta:
model = RelatedModel
fields = ('id', 'name')


class SomeModelSerializer(serializers.ModelSerializer):
related_model = AsymmetricRelatedField(
serializer_class=RelatedModelSerializer,
queryset=RelatedModel.objects.all()
)

class Meta:
model = SomeModel
fields = ('id', 'name', 'related_model')
53 changes: 53 additions & 0 deletions tests_app/tests/unit/fields/tests.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
from django.test import TestCase
from rest_framework import serializers
from .models import SomeModel, RelatedModel
from .serializers import SomeModelSerializer, RelatedModelSerializer
from rest_framework_extensions.fields import AsymmetricRelatedField


class TestAsymmetricRelatedField(TestCase):
def setUp(self):
self.related_model1 = RelatedModel.objects.create(name='related_model1')
self.related_model2 = RelatedModel.objects.create(name='related_model2')
self.some_model = SomeModel.objects.create(
name='some_model', related_model=self.related_model1)

def test_to_representation(self):
field = AsymmetricRelatedField(serializer_class=RelatedModelSerializer)
result = field.to_representation(self.related_model1)
self.assertEqual(
result, {'id': self.related_model1.id, 'name': 'related_model1'})

def test_create(self):
data = {
'name': 'new_some_model',
'related_model': self.related_model2.id
}
serializer = SomeModelSerializer(data=data)
self.assertTrue(serializer.is_valid())
instance = serializer.save()
self.assertEqual(instance.name, 'new_some_model')
self.assertEqual(instance.related_model, self.related_model2)

def test_update(self):
data = {
'name': 'updated_some_model',
'related_model': self.related_model2.id
}
serializer = SomeModelSerializer(
instance=self.some_model, data=data, partial=True)
self.assertTrue(serializer.is_valid())
instance = serializer.save()
self.assertEqual(instance.name, 'updated_some_model')
self.assertEqual(instance.related_model, self.related_model2)

def test_read(self):
serializer = SomeModelSerializer(instance=self.some_model)
self.assertEqual(serializer.data, {
'id': self.some_model.id,
'name': 'some_model',
'related_model': {
'id': self.related_model1.id,
'name': 'related_model1'
}
})
19 changes: 19 additions & 0 deletions tests_app/tests/unit/migrations/0001_initial.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,23 @@ class Migration(migrations.Migration):
('users_liked', models.ManyToManyField(blank=True, to='unit.UserModel')),
],
),
migrations.CreateModel(
name='RelatedModel',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True,
serialize=False, verbose_name='ID')),
('name', models.CharField(max_length=100)),
],
),
migrations.CreateModel(
name='SomeModel',
fields=[
('id', models.AutoField(auto_created=True, primary_key=True,
serialize=False, verbose_name='ID')),
('name', models.CharField(max_length=100)),
('related_model',
models.ForeignKey(blank=True, to='unit.RelatedModel',
on_delete=models.CASCADE)),
],
),
]
Loading