Simplify "cpuinfo" subcommand check #2633
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command "cpuinfo" requires a subcommand "dump" or "check". - `CR_CPUINFO` is removed; `CR_CPUINFO_DUMP` and `CR_CPUINFO_CHECK` are added in its place. - All parsing is now done in `parse_criu_mode`, removing need for passing string subcommand to `image_dir_mode`. - Check for valid subcommand is done once at the start with only the enum `CR_CPUINFO_DUMP` or `CR_CPUINFO_CHECK` propagated on success, rather than propagating both `CR_CPUINFO` and the subcommand string while doing `strcmp` on each call to `image_dir_mode`. Signed-off-by: Liana Koleva <[email protected]>
How does it affect existing users who use CR_CPUINFO? |
|
@avagin Could you share an example? |
|
@lianakoleva I think I messed up when I was trying to read this code last time. CR_CPUINFO is a completely internal thing and it isn't a part of our public interface. |
|
A friendly reminder that this PR had no activity for 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command "cpuinfo" requires a subcommand "dump" or "check".
CR_CPUINFOis removed;CR_CPUINFO_DUMPandCR_CPUINFO_CHECKare added in its place.parse_criu_mode, removing need for passing string subcommand toimage_dir_mode.CR_CPUINFO_DUMPorCR_CPUINFO_CHECKpropagated on success, rather than propagating bothCR_CPUINFOand the subcommand string while doingstrcmpon each call toimage_dir_mode.