Having issue to compile criu 1.2 on Ubuntu

[bugrax]

Hi Guys,
I tried to install criu on precise and trusty,I went through the installation process of protobuf,protobuf-c and stuck on criu. I am getting this error when I do make && make config && make install:
pie/restorer.c: In function ‘restore_mapping’:
pie/restorer.c:355:21: error: expected ‘)’ before ‘PRIx64’
pr_debug("\tmmap(%"PRIx64" -> %"PRIx64", %x %x %d)\n",

Thanks

[avagin]

Could you try to define __STDC_FORMAT_MACROS?
make V=1 USERCFLAGS="-D__STDC_FORMAT_MACROS"

[bugrax]

Hi Avagin, this is the output
bash -c "echo 'OUTPUT_ARCH(i386:x86-64)' > pie/pie.lds.S"
bash -c "cat pie/pie.lds.S.in >> pie/pie.lds.S"
ld -T pie/pie.lds.S -o pie/parasite.built-in.bin.o pie/parasite.built-in.o
objcopy -O binary pie/parasite.built-in.bin.o pie/parasite.built-in.bin
bash pie/../scripts/gen-offsets.sh pie/parasite parasite > pie/parasite-blob.h
gcc -c -D__STDC_FORMAT_MACROS -O2 -Wall -Werror -DCONFIG_X86_64 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -iquote include -iquote pie -iquote . -iquote arch/x86 -iquote arch/x86/include -fno-strict-aliasing -DCR_NOGLIBC -fpie -Wa,--noexecstack -fno-stack-protector pie/restorer.c -o pie/restorer.o
pie/restorer.c: In function ‘restore_mapping’:
pie/restorer.c:355:2: error: expected ‘)’ before ‘PRIx64’
pie/restorer.c:355:2: error: spurious trailing ‘%’ in format [-Werror=format]
pie/restorer.c: In function ‘__export_restore_task’:
pie/restorer.c:706:4: error: expected ‘)’ before ‘PRIx64’
pie/restorer.c:706:4: error: format ‘%s’ expects a matching ‘char ’ argument [-Werror=format]
pie/restorer.c:706:4: error: format ‘%d’ expects a matching ‘int’ argument [-Werror=format]
pie/restorer.c:706:4: error: spurious trailing ‘%’ in format [-Werror=format]
pie/restorer.c:755:6: error: expected ‘)’ before ‘PRIx64’
pie/restorer.c:755:6: error: format ‘%s’ expects a matching ‘char *’ argument [-Werror=format]
pie/restorer.c:755:6: error: format ‘%d’ expects a matching ‘int’ argument [-Werror=format]
pie/restorer.c:755:6: error: spurious trailing ‘%’ in format [-Werror=format]
cc1: all warnings being treated as errors
make[1]: ** [pie/restorer.o] Error 1
make[1]: Leaving directory `/root/criu'

[cyrillos]

could you please add

#include <inttypes.h>

somewhere at top of pie/restorer.c (ie near other #include there) and check if it help?

[cyrillos]

#include <inttypes.h> I mean

[cyrillos]

Or you can grab patch from https://bugzilla.openvz.org/show_bug.cgi?id=2949 and test if it fixes the problem (download it then do git am "patch filename" and compile the criu)

[bugrax]

@cyrillos patch works! I tested. Thanks

[cyrillos]

Thanks! I'll send it upstream.

[cyrillos]

Could you very please test an updated version of the patch? https://bugzilla.openvz.org/show_bug.cgi?id=2949

[xemul]

xemul@0c89d77