Add Content Security Policy #879
Conversation
ChibiBlasphem
force-pushed
the
poc/csp
branch
4 times, most recently
from
f09330e to
a9b8945
Compare
ChibiBlasphem
force-pushed
the
poc/csp
branch
3 times, most recently
from
8447473 to
7544e91
Compare
| FIREBASE_APP_ID: z.string().optional(), | ||
| METABASE_URL: z.string().optional(), | ||
|
|
||
| // FIREBASE_AUTH_EMULATOR_HOST: z.string().optional(), |
There was a problem hiding this comment.
should we keep this commented line ?
| const [err, appConfig] = await tryit(() => appConfigRepository.getAppConfig())(); | ||
|
|
||
| if (ssoResponse.status === 'rejected') { | ||
| console.error('Error fetching internal SSO-enabled API'); | ||
| } | ||
| if (signInStatusResponse.status === 'rejected') { | ||
| console.error('Error fetching internal signup-status API'); | ||
| if (err) { |
There was a problem hiding this comment.
Silly question: Should we consider tryit a standard?
I’d naturally lean toward using a regular try/catch block in this case, but I’m okay with adopting this method more if that’s the direction we’re going.
There was a problem hiding this comment.
Error values > Exceptions 🥷
There was a problem hiding this comment.
let the religion wars begin 🙊
joke aside, I rather like go's error values, but I wonder too if it's idiomatic in js 🤔
There was a problem hiding this comment.
I wasn't really opinionated before needing to no repeat code uselessly.
| const [err, appConfig] = await tryit(() => appConfigRepository.getAppConfig())(); | ||
|
|
||
| if (ssoResponse.status === 'rejected') { | ||
| console.error('Error fetching internal SSO-enabled API'); | ||
| } | ||
| if (signInStatusResponse.status === 'rejected') { | ||
| console.error('Error fetching internal signup-status API'); | ||
| if (err) { |
There was a problem hiding this comment.
let the religion wars begin 🙊
joke aside, I rather like go's error values, but I wonder too if it's idiomatic in js 🤔
ChibiBlasphem
force-pushed
the
poc/csp
branch
2 times, most recently
from
2acc69e to
e34b609
Compare
No description provided.