Skip to content

chore: update packaging to match main chart.js library #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

benmccann
Copy link
Collaborator

closes #78

@kurkle
Copy link
Member

kurkle commented Nov 17, 2022

Karma needs the umd one, need to change that. I guess the unminified one would be better there, but as these are so simple libs, I guess it does not really matter.

@benmccann benmccann force-pushed the packaging branch 2 times, most recently from d4de198 to 9b97603 Compare November 17, 2022 21:21
@benmccann
Copy link
Collaborator Author

This is passing the CI and ready for review now

@benmccann benmccann requested a review from kurkle November 19, 2022 19:14
@kurkle kurkle merged commit bdc72c1 into chartjs:master Nov 19, 2022
@benmccann benmccann deleted the packaging branch November 19, 2022 23:37
@benmccann
Copy link
Collaborator Author

Thanks @kurkle! Any chance we could get a new release?

@benmccann
Copy link
Collaborator Author

@kurkle just checking in to see if we can get a new release. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import issue with chartjs-adapter-luxon 1.2.1
2 participants