-
Notifications
You must be signed in to change notification settings - Fork 12k
Description
Expected behavior
When a PR is submitted, the test cases should end correctly both Chrome and FF.
Current behavior
If you see the history of the CI, you can see that the last one which ended correctly (testing the cases) was using FF 109. Starting using 110, the fixture test cases are failing randomly. And as @dangreen reported, locally it works correctly.
Reproducible sample
https://github.com/chartjs/Chart.js/actions/runs/4255610081/jobs/7403444754
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
I had a look to new feature of FF 110: https://www.mozilla.org/en-US/firefox/110.0/releasenotes/
I see the following feature which could affect us: GPU-accelerated Canvas2D is enabled by default on macOS and Linux.
having a look to what was done in annotation plugin, we could disable canvas acceleration (not sure if the property is the correct one, :() with the following Karma config:
customLaunchers: {
chrome: {
base: 'Chrome',
flags: [
'--disable-accelerated-2d-canvas',
'--disable-background-timer-throttling',
'--disable-backgrounding-occluded-windows',
'--disable-renderer-backgrounding'
]
},
firefox: {
base: 'Firefox',
prefs: {
'layers.acceleration.disabled': true,
'gfx.canvas.accelerated': false // <--- added this one!!! --->
}
}
},
and CI in the plugin should end correctly.
chart.js version
v4.2.1
Browser name and version
FF 110
Link to your project
No response