-
Notifications
You must be signed in to change notification settings - Fork 155
fix: add CORS to config, improve test #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
==========================================
- Coverage 51.96% 51.77% -0.19%
==========================================
Files 157 159 +2
Lines 13454 13572 +118
==========================================
+ Hits 6991 7027 +36
- Misses 5891 5973 +82
Partials 572 572 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
53a164e
to
c2b7598
Compare
Thank you for the changes @fetsorn! I will merge once the tests pass |
I also added several allowed headers needed for preflight requests |
readded the changes since they were reverted on main. all checks but lint pass, and lint fails outside cors |
Is merging this still blocked by something or just waiting in queue? |
Hi @fetsorn! Thank you again for working on this major feature. Sorry for the delay, but I've been working on #678 and trying to get Soft Serve to use the new v2 stack. I thought CORS is a good feature to pair with v2 in the next release. Once I get #678 merged, very soon, I will merge this one and push a new v0.9.0 Soft Serve release 🙂 |
Hotfix for #516, I've corrected the test case and added CORS to the default config.